-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 20653 mobile home shipment card #13620
B 20653 mobile home shipment card #13620
Conversation
Some of the things I've noticed while testing the functionality - There is a remarks field on the 1st page and another on the 2nd page which can be removed. And also when I edit, the pickup address doesn't seem to populate with existing data. |
Ah actually I see why they gotta go I have the remarks already on the location page, I'll get rid of those. I'm working on seeing why the pickupaddress isn't populating on edit now |
Yeah, sorry I could have been more clear. For boat I have the remarks on the 1st page and not on the location page. And for the description - yeah... not sure because the boat story had a mockup with those description already in it, but I don't see one for Mobile home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing: Success w/1 issue (see comment)
Code: lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good! Code looks good and meets AC. I did notice the AC is
"Given a Mobile Home shipment has been created,
When a customer reviews their boat
shipment,"
and that When
should probably refer to the mobile home shipment rather than boat
Inserting myself into this PR so forgive me if any of these are supposed to be this way, but noticed a few other small things. If all instances of the words "mobile home" should be "Mobile Home" I see a few spots without that capitalization - "Mobile home Information", "Mobile home details and measurements"
Also not sure if they need to be capitalized mid-sentence down in the remarks section here. However, I do see a typo where "signigicantly" should be "significantly"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment because I am also looking at Aaron's changes for the office users - can we make the destination address field match? I'm good with either Destination
or Destination address
, whatever you both agree on. Just would like it to be the same if it's not too big of a deal :)
Destination
for customer on the left bottom vs Destination address
for office user on the right bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once you get any straggling errors cleaned up 👽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Checked update. issue resolved. |
B-20653
Summary
This PR updates the mobile home shipment status to 'SUBMITTED' when the shipment is submitted by the customer.
This also removes 'Please' from the shipment option description, and updates the shipment opiton description to match the PO AC.
Any labeling for Mobile home that's user facing is now "Mobile Home".
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
ANDI Screenshots
Removed location Page title
Removed Please from shipment list description
Change of dimension description
Shipment Option label change
Shipment Card label change